-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Mermaid support #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid support #830
Conversation
|
@asokolsky thanks for the PR! Unfortunately, Jekyll doesn't pick up your default settings from remote_theme: asokolsky/just-the-docs@issue825For building locally, I have also this in my gem "just-the-docs", github: "asokolsky/just-the-docs", branch: "issue825"I haven't added any Also the variable I'm not sure how Jekyll determines just which settings from the theme's Unless any of the other @just-the-docs/maintainers have better suggestions, you should probably make |
Agreed - let's not ship a change like this to be on by default. This should be consciously toggled on by users. |
|
Definitely agree to keep it off by default. Could we also add a bit more to the documentation to explain what Mermaid is, and how to enable it / various configuration options? |
|
This would be great functionality to add - let me know if there's any help needed 👍 |
|
This might be my fault, but when testing this locally it looks like we'd need to make the Edit: Looks like it's the Lines 6 to 12 in 7631aaa
Potentially we could just add an extra rule to override the theme for mermaid diagrams: code.language-mermaid {
padding: 0;
background-color: inherit;
border: none
}That combined with changing the theme to |
| # pick from https://cdnjs.com/libraries/mermaid | ||
| mermaid_version: "9.0.0" | ||
| # choices: https://mermaid-js.github.io/mermaid/#/theming | ||
| mermaid_theme: "forest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
For now, closing this in favour of #857. Feel free to reopen! |



#825
_config.yaml options added: