🌱 Priorityqueue tests: Use synctest #3350
Merged
+328
−291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2867fbe to
3efb516
Compare
Member
Author
|
/hold |
3efb516 to
ea64e21
Compare
Member
|
Thx! /lgtm Backporting tests won't be much fun for a bit :) |
Contributor
|
LGTM label has been added. DetailsGit tree hash: a8b4925c2d795cbe6ca43abfc7c9c7f7d8510bf4 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves all tests in the priorityqueue where it makes sense to use synctest. Synctest provides a
Waitfunc we can use to wait until all goroutines in the test are durably blocked. This allows us to block after anAddcall until the priorityqueue has finished processing. Because we didn't have that, we previously usedtime.SleepandEventuallyif we wanted something to happen andConsistentlyif we wanted to assert that something does not happen. With this change, we don't need any of those three anymore.Because ginkgo doesn't support synctest, this change entails that we have to stop using it. To simplify reviewing, I've moved the tests from ginkgo to go test in the first commit and updated them to use synctest in the second commit.