Skip to content

Provide GraalVM native-image --initialize-at-build-time args #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ikitommi merged 1 commit into from
Sep 13, 2021
Merged

Provide GraalVM native-image --initialize-at-build-time args #58

ikitommi merged 1 commit into from
Sep 13, 2021

Conversation

@kwojcik-blockether
Copy link
Contributor

@kwojcik-blockether kwojcik-blockether commented Sep 13, 2021

As clj-easy/graal-build-time states:

From GraalVM 22 onwards, the native-image global --initialize-at-build-time option will be deprecated. This means you will have to list every package that you want to initialize at build time separately, like initialize-at-build-time=clojure,my_library

Without now discouraged --initialize-at-build-time with no arguments passed the native-image tool fails to build the project that depends on metosin/jsonista. This is due to the fact, that some of the com.fasterxml.jackson classes are initialized unconditionally in core.clj.

The following changes auto provides the necessary jsonista configurations to GraalVM native-image, are backward compatible for all GraalVM jsonista users, and should not introduce any breakage.

@kwojcik-blockether
Add META-INF with native-image.properties
5b8dd2c 
As `clj-easy/graal-build-time` states:

> From GraalVM 22 onwards, the native-image global --initialize-at-build-time option will be deprecated. This means you will have to list every package that you want to initialize at build time separately, like initialize-at-build-time=clojure,my_library

Without now discouraged `--initialize-at-build-time` with no arguments passed the `native-image` tool fails to build the project that depends on `metosin/jsonista`. This is due to the fact, that some of the `com.fasterxml.jackson` classes are initialized unconditionally in `core.clj`.

The following changes auto provides the necessary `jsonista` configurations to GraalVM `native-image`, are backward compatible for all GraalVM `jsonista` users, and should not introduce any breakage.
@borkdude
Copy link

borkdude commented Sep 13, 2021

Look good to me. Perhaps also add "resources" to :paths` in deps.edn.

@kwojcik-blockether
Copy link
Contributor Author

kwojcik-blockether commented Sep 13, 2021

@borkdude do you see everything I do on Github? 👀 😆

Actually, I can update deps.edn to match the dependencies, resources of project.clj if necessary. Should I @ikitommi?

@borkdude
Copy link

borkdude commented Sep 13, 2021

I am subscribed to jsonista issues ;).

@ikitommi
Copy link
Member

ikitommi commented Sep 13, 2021

Updating the dependencies in two places is no fun, it would be better to lift this as deps-project. PR most welcome on that. (jmh-test too)

@ikitommi ikitommi merged commit a88ef89 into metosin:master Sep 13, 2021
@kwojcik-blockether
Copy link
Contributor Author

kwojcik-blockether commented Sep 13, 2021

Huh. That was fast. Could we please release the new version of jsonista with just this change? 🙏

@opqdonut
Copy link
Member

opqdonut commented Sep 16, 2021

https://clojars.org/metosin/jsonista/versions/0.3.4

let me know if that works for you

@kwojcik-blockether
Copy link
Contributor Author

kwojcik-blockether commented Sep 16, 2021

Works perfectly fine:

...
-imagecp \
/opt/graalvm-ce-java8-21.2.0/jre/lib/boot/graaljs-scriptengine.jar:/opt/graalvm-ce-java8-21.2.0/jre/lib/boot/graal-sdk.jar:/project/.holy-lambda/build/output.jar:/opt/graalvm-ce-java8-21.2.0/jre/lib/svm/library-support.jar \
-H:Path=/project/.holy-lambda/build \
'-H:Class@manifest from file:///project/.holy-lambda/build/output.jar=com.compan
y.example_lambda.core' \
'-H:Name@manifest from file:///project/.holy-lambda/build/output.jar=output' \
'-H:ClassInitialization@jar:file:///project/.holy-lambda/build/output.jar!/META-
INF/native-image/metosin/jsonista/native-image.properties=com.fasterxml.jackson:
build_time' \ <-- SEE HERE
'-H:ClassInitialization@jar:file:///project/.holy-lambda/build/output.jar!/META-
INF/native-image/metosin/jsonista/native-image.properties=jsonista:build_time' \ <-- SEE HERE
-H:ConfigurationFileDirectories=native-configuration \
-H:FallbackThreshold=0 \
-H:EnableURLProtocols=http,https \
-H:+ReportUnsupportedElementsAtRuntime \
-H:+AllowIncompleteClasspath \
-H:CLibraryPath=/opt/graalvm-ce-java8-21.2.0/jre/lib/svm/clibraries/linux-amd64
]

Thank you so much @ohpauleez @ikitommi @borkdude :)

@borkdude
Copy link

borkdude commented Sep 21, 2021

Just as a FYI:

This is due to the fact, that some of the com.fasterxml.jackson classes are initialized unconditionally in core.clj.

This can usually be prevented by wrapping those top-level-ns instances in delays. If that's possible, this is the preferred solution, but this would perhaps break users of those top-level vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kwojcik-blockether @borkdude @ikitommi @opqdonut