Skip to content

fix(ui): fix washed out dropdown colors in dark mode#34186

Merged
agg23 merged 4 commits into
microsoft:mainfrom
JustasMonkev:fix/dark-mode-dropdown-colors
Jan 8, 2025
Merged

fix(ui): fix washed out dropdown colors in dark mode#34186
agg23 merged 4 commits into
microsoft:mainfrom
JustasMonkev:fix/dark-mode-dropdown-colors

Conversation

@JustasMonkev

@JustasMonkev JustasMonkev commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

This patch enforces a dark-mode-friendly background and text color on the dropdown elements.

previously
image
with the fix

image

image

References #33931

This patch enforces a dark-mode-friendly background and text color on the dropdown elements.
No new dependencies introduced.

References microsoft#33931
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › by default › loopback address @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37473 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman requested a review from agg23 January 2, 2025 14:52

@agg23 agg23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@agg23 agg23 merged commit d6d5944 into microsoft:main Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants