Increase max file size for file comparison #127860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As vs code is often used in professional environment, it's usual to compare very big log files for debug purposes. Current limit is too small and I often end up with `Cannot compare files because one file is too large.` error. Development machines usually have a lot of RAM installed and often have SSD drives, so bigger limit should not be a problem.
alexdima
requested changes
Jul 5, 2021
Member
alexdima
left a comment
There was a problem hiding this comment.
This particular constant is used for multiple purposes. One purpose is the diffing, but others include: syncing to the extension host, computing links, etc. At least on the extension host, many extensions are not prepared to deal with such large files. I therefore suggest that diffing itself is improved in a (local) way that is independent of the other usages.
This change increases max file size for diff option, without affecting other syncing operations.
|
|
Contributor
Author
|
@alexdima is my PR ok? |
Contributor
Author
Member
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As vs code is often used in professional environment, it's usual to compare very big log files for debug purposes. Current limit is too small and I often end up with
Cannot compare files because one file is too large.error. Development machines usually have a lot of RAM installed and often have SSD drives, so bigger limit should not be a problem.This PR fixes #
Increases limit of file size for file comparison feature.