Skip to content

Update select to matching bracket direction #128931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexdima merged 3 commits into from
Aug 17, 2021
Merged

Update select to matching bracket direction #128931

alexdima merged 3 commits into from
Aug 17, 2021

Conversation

@ssigwart
Copy link
Contributor

@ssigwart ssigwart commented Jul 18, 2021

This PR fixes #128930.

This selected from the end to start position when selecting to matching bracket.

Automated tests

./scripts/test.sh --glob **/bracketMatching.test.js

Manual testing

  1. Select from the } (using editor.action.selectToBracket) in this, then use Shift + Up:
// Shift+ up
function shiftUpTest()
{
	var i = 0
}
  1. Select to matching bracket when the cursor is within the </div> (using editor.emmet.action.balanceOut) in this, then use Shift + Up:
<html>
	<body>
		<div>
			<h1>Test</h1>
		</div>
	</body>
</html>

@rzhao271 rzhao271 requested review from alexdima and rzhao271 July 19, 2021 19:01
@rzhao271 rzhao271 added this to the July 2021 milestone Jul 19, 2021
@rzhao271
Copy link
Collaborator

rzhao271 commented Jul 19, 2021

The Emmet part of the diff looks good to me!
I'll let @alexdima review the rest.

@rzhao271 rzhao271 modified the milestones: July 2021, August 2021 Jul 30, 2021
@alexdima alexdima merged commit 58b670c into microsoft:main Aug 17, 2021
@ssigwart ssigwart deleted the matchBrace branch August 18, 2021 00:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexdima alexdima alexdima approved these changes

@rzhao271 rzhao271 Awaiting requested review from rzhao271

Assignees

@rzhao271 rzhao271

Labels

None yet

Projects

None yet

Milestone

August 2021

Development

Successfully merging this pull request may close these issues.

Select to Matching Bracket direction should be end position to start position.

3 participants

@ssigwart @rzhao271 @alexdima