-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Add a special entry when disassembly is unavailable #129797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am not sure this is the best approach. Visually it might not look so good, and users might need to close it manually which can be a pain. First important thing to figure out, do users want to inspect Disassembly after they stopped debugging. If YES, I propose the following:
If NO
In both these cases we would not need a placeholder solution like the one proposed in this PR. |
|
@isidorn Yes users may want to inspect disassembly after they stopped debugging.
We can't do this because disassembly is only available on debug pause, such as a breakpoint hit. |
|
@xisui-MSFT okey, but once debugging is paused again please re-use the current disassembly view. And also make sure to close it on vscode shutdown so it is not left over for user to manage. |
|
@isidorn Sometimes the view could be empty when the debugger or debug adapter have some bugs. For example, microsoft/vscode-cpptools#7960. We were planning to add more special entries as we move forward, and so have a consistent way of showing errors or hints for users. As for this message in this PR, we could keep it as it is or probably change it to something like "Pause debugging or hit a breakpoint for disassembly".
Yes, there is only one disassembly view currently.
I'm not sure if I need to do anything extra here? The default behavior seems to be closing the view when closing VS Code. |
|
@xisui-MSFT ok, all makes sense. Let me know once this PR is ready to be reviewed / merged. Thanks |
|
While ready for review, it's hard for me to do complex changes right now because of this issue: #130947 |
|
@xisui-MSFT thanks for this PR, this looks good to me. Let's merge it in. |
This PR fixes #129526
Add a special entry to show text 'Disassembly not available' when the disassembly view is empty.