Skip to content

feat: add .tpp and .txx as c++ extensions #130101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexr00 merged 1 commit into from
Aug 5, 2021
Merged

feat: add .tpp and .txx as c++ extensions #130101

alexr00 merged 1 commit into from
Aug 5, 2021

Conversation

@threeal
Copy link
Contributor

@threeal threeal commented Aug 4, 2021

Signed-off-by: Alfi Maulana alfi.maulana.f@gmail.com

Add .tpp and .txx as extensions of C++ template implementation (alternative for .ipp and .ixx).

@threeal
feat: add .tpp and .txx as c++ extensions
4452340 
Signed-off-by: Alfi Maulana <alfi.maulana.f@gmail.com>
@hediet hediet requested review from alexr00 and removed request for alexr00 August 4, 2021 14:15
alexr00
alexr00 requested changes Aug 4, 2021
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@threeal can you point me to some documentation that explains why those two file extensions should be C++?

@threeal
Copy link
Contributor Author

threeal commented Aug 5, 2021

@alexr00 as in this question, both *.tpp and *.ipp are used in template implementation, Boost usually use *.ipp and some other users use *.tpp.

Cppcheck recognize *.tpp and *.txx as c++ extensions but not *.ipp and *.ixx (which VS Code already recognized).
https://github.com/danmar/cppcheck/blob/27a4df06d20fcc09cf7be6ee5f501baa0c2c1b5c/cli/cmdlineparser.cpp#L975-L976

@alexr00 alexr00 added this to the August 2021 milestone Aug 5, 2021
@alexr00 alexr00 merged commit 0f99773 into microsoft:main Aug 5, 2021
alexr00
alexr00 approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2021
@threeal threeal deleted the add-cpp-extensions branch December 10, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@alexr00 alexr00

Labels

None yet

Projects

None yet

Milestone

August 2021

Development

Successfully merging this pull request may close these issues.

2 participants

@threeal @alexr00