[Standalone editor] Add support to list provided code action kinds when registering a CodeActionProvider
#131254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deActionProvider` in the standalone editor
spahnke
commented
Aug 20, 2021
| * Register a code action provider (used by e.g. quick fix). | ||
| */ | ||
| export function registerCodeActionProvider(languageId: string, provider: CodeActionProvider): IDisposable; | ||
| export function registerCodeActionProvider(languageId: string, provider: CodeActionProvider, metadata?: CodeActionProviderMetadata): IDisposable; |
Contributor
Author
There was a problem hiding this comment.
I added these by hand, but I'm unsure if there is a generation process of this file involved somewhere. Or is it only the final monaco.d.ts that's shipped with the NPM package that's generated from this one?
Member
There was a problem hiding this comment.
I think it is being generated, but the outcome would be the same.
Member
|
Thank you for your PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes microsoft/monaco-editor#2625
Added a third optional parameter
metadataonregisterCodeActionProviderthe same way the VS Code extension API does it, so that embedders of the Monaco editor can list the provided code action kinds and get support for theeditor.action.autoFixaction, as well as the "Refactor..." and "Source Action..." context menu entries. I copied over the typeCodeActionProviderMetadatafromvscode.d.tsintomonaco.d.tsand just kept theprovidedCodeActionKindsproperty, adjusting the type and documentation wording accordingly.