-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Added ariaContainerElement to IStandaloneEditorConstructionOptions
#131865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To test, run monaco editor shadow dom test: microsoft/monaco-editor#2644 |
|
I'm trying to take advanatge of this change. My package.json has |
|
@simonh1000 this change hasn't been released yet, it's part of the September 2021 milestone, so you'll have to join me in waiting! |
|
@simonh1000 What is the problem? I'm not sure I understand from the screenshot. The property |
|
document.querySelector returns an |
|
The typing we ship is correct. We expect an |
|
For anyone coming later, one way around the typescript error is |
|
@simonh1000 |

This PR fixes issues with ARIA when using the standalone editor in shadow DOM: microsoft/monaco-editor#619