Skip to content

Added Enabled View to Extension Viewlet#25974

Closed
gonzofish wants to merge 3 commits into
microsoft:masterfrom
gonzofish:master
Closed

Added Enabled View to Extension Viewlet#25974
gonzofish wants to merge 3 commits into
microsoft:masterfrom
gonzofish:master

Conversation

@gonzofish

Copy link
Copy Markdown

Addresses #22866

Added Enabled action to extensions viewlet
Added "Extensions: Show Enabled Extensions" action to workbench
Set showing enabled in extensions to default view when opening extensions viewlet

Matt Fehskens added 2 commits May 4, 2017 23:24
Set it to default extensions pane to enabled
Added action to command palette as well
@mention-bot

Copy link
Copy Markdown

@gonzofish, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @joaomoreno to be potential reviewers.

@msftclas

msftclas commented May 5, 2017

Copy link
Copy Markdown

@gonzofish,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas

msftclas commented May 5, 2017

Copy link
Copy Markdown

@gonzofish, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@joaomoreno joaomoreno requested review from joaomoreno and sandy081 May 5, 2017 06:23
@joaomoreno joaomoreno self-assigned this May 5, 2017
@joaomoreno joaomoreno added this to the May 2017 milestone May 5, 2017

@joaomoreno joaomoreno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that the user can filter out the disabled extensions. But I don't think that should be the default behaviour. I would keep the @installed view as the default behaviour.

@gonzofish

gonzofish commented May 5, 2017 via email

Copy link
Copy Markdown
Author

@joaomoreno joaomoreno modified the milestones: May 2017, June 2017 May 24, 2017
@leocaseiro

Copy link
Copy Markdown

I was wondering if this feature is ready to be merged.

I'm happy to give some help.

Thanks

@gonzofish

Copy link
Copy Markdown
Author

Yeah me too. I updated it as requested but never heard anything after.

@sandy081

Copy link
Copy Markdown
Member

@gonzofish Sorry for not looking into this.. I will take a look.. But may I know is it possible to resolve the conflicts?

@gonzofish

Copy link
Copy Markdown
Author

@sandy081 no worries! I hadn't noticed the conflicts. I can definitely fix them today.

@joaomoreno joaomoreno modified the milestones: June 2017, Backlog Jun 26, 2017
@leocaseiro

leocaseiro commented Jul 6, 2017

Copy link
Copy Markdown

Hi @gonzofish, I don't want to be "push", so I was wondering If you could give me access to this branch, so I can help fixing the conflicts, in case you've been busy.

Thanks

@BuraChuhadar

BuraChuhadar commented Jul 11, 2017

Copy link
Copy Markdown
Contributor

@sandy081 this is #30367 on top of @gonzofish's changes which only fixes the merge conflicts.

@sandy081

Copy link
Copy Markdown
Member

@bugrac Thanks. Will take a look.

@sandy081 sandy081 modified the milestones: July 2017, Backlog Jul 11, 2017
@gonzofish

Copy link
Copy Markdown
Author

@bugrac thanks for updating in my absence

I had some things come up and was away from Internet access for the last week, sorry for the radio silence

@joaomoreno joaomoreno assigned sandy081 and unassigned joaomoreno Jul 24, 2017
@sandy081

Copy link
Copy Markdown
Member

@gonzofish Merged the PR from @bugrac.

@sandy081 sandy081 closed this Jul 25, 2017
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants