Skip to content

grid-row-start property browser support info#35

Merged
aeschli merged 2 commits into
microsoft:masterfrom
praveenpuglia:css-grid-row-start
Jul 10, 2017
Merged

grid-row-start property browser support info#35
aeschli merged 2 commits into
microsoft:masterfrom
praveenpuglia:css-grid-row-start

Conversation

@praveenpuglia

@praveenpuglia praveenpuglia commented Jul 7, 2017

Copy link
Copy Markdown
Contributor

CC : microsoft/vscode#27590

  • One thing I noticed is that even though css-schema.xml has the description for the span value, in built browsers.js it's not showing up. @aeschli - please help with this.

@msftclas

msftclas commented Jul 7, 2017

Copy link
Copy Markdown

@praveenpuglia,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@praveenpuglia

Copy link
Copy Markdown
Contributor Author

@aeschli - can we also publish a newer version to npm after this is merged? That way vscode will get the new support info automatically in next build.

@aeschli

aeschli commented Jul 7, 2017

Copy link
Copy Markdown
Collaborator

Thanks @praveenpuglia !

Yes, I'll create a version and update VSCode so this gets in the next release of VSCode.

@aeschli aeschli added this to the July 2017 milestone Jul 7, 2017
@aeschli aeschli merged commit a93e34f into microsoft:master Jul 10, 2017
@praveenpuglia praveenpuglia deleted the css-grid-row-start branch July 10, 2017 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants