Fix bug where the WasmWorker instance is disposed but never re-spawned on page reloads + writeMemory when WASM memory is SharedArrayBuffer#2211
Merged
connor4312 merged 1 commit intomicrosoft:mainfrom May 1, 2025
mikaelwaltersson:fix-wasm-worker-dispose-bug
Merged
Fix bug where the WasmWorker instance is disposed but never re-spawned on page reloads + writeMemory when WASM memory is SharedArrayBuffer#2211connor4312 merged 1 commit intomicrosoft:mainfrom mikaelwaltersson:fix-wasm-worker-dispose-bug
connor4312 merged 1 commit intomicrosoft:mainfrom
mikaelwaltersson:fix-wasm-worker-dispose-bug
Conversation
…d on page reloads + writeMemory when WASM memory is SharedArrayBuffer
rzhao271
approved these changes
May 1, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
WasmWorkerFactoryinstance caches a singleIWasmWorkerinstance but thedisposemethod on theIWasmWorkerinstance still terminates the underlying worker. The effect is that the worker in the@vscode/dwarf-debuggingterminates on browser page reloads and never re-spawns again until debugging is restarted.This PR addresses this issue by still caching a single
IWasmWorkerinstance but re-spawning it if the previous call todisposecaused the "ref count" to reach zero.Possible related to microsoft/vscode-dwarf-debugging#6
Also fixes
writeMemorywhen WASM memory isSharedArrayBuffer.