Skip to content

Port variable restart fix#9938

Merged
rchiodo merged 4 commits intorelease-2020.02from
rchiodo/variable_restart_release
Feb 6, 2020
Merged

Port variable restart fix#9938
rchiodo merged 4 commits intorelease-2020.02from
rchiodo/variable_restart_release

Conversation

@rchiodo
Copy link

@rchiodo rchiodo commented Feb 6, 2020

No description provided.

rchiodo and others added 3 commits February 5, 2020 16:09
@rchiodo rchiodo added the no-changelog No news entry required label Feb 6, 2020
@rchiodo rchiodo self-assigned this Feb 6, 2020
IanMatthewHuff
IanMatthewHuff reviewed Feb 6, 2020
View reviewed changes
CHANGELOG.md

## Version 0.0.3
* Added support for debugging using PDB
* Added support for debugging using PDB No newline at end of file
Copy link
Member

@IanMatthewHuff IanMatthewHuff Feb 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, what's this? Looks the same...

Copy link
Author

@rchiodo rchiodo Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line feed maybe? I just auto generated it.

@codecov-io
Copy link

codecov-io commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #9938 into release-2020.02 will decrease coverage by 0.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2020.02   #9938      +/-   ##
==================================================
- Coverage            61.21%   61.2%   -0.02%     
==================================================
  Files                  564     564              
  Lines                30061   30077      +16     
  Branches              4545    4550       +5     
==================================================
+ Hits                 18403   18408       +5     
- Misses               10629   10639      +10     
- Partials              1029    1030       +1
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø) ⬆️
src/client/datascience/jupyter/jupyterServer.ts 8.33% <0%> (ø) ⬆️
...datascience/jupyter/liveshare/hostJupyterServer.ts 11.11% <0%> (-1.25%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 16.96% <0%> (ø) ⬆️
...ient/datascience/interactive-ipynb/nativeEditor.ts 56.98% <100%> (+0.27%) ⬆️
...client/datascience/jupyter/jupyterServerWrapper.ts 30.23% <33.33%> (+1.66%) ⬆️
...lient/datascience/jupyter/liveshare/serverCache.ts 65.33% <66.66%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a19d655...0d77355. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo rchiodo merged commit ed09569 into release-2020.02 Feb 6, 2020
@rchiodo rchiodo deleted the rchiodo/variable_restart_release branch February 6, 2020 16:17
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

+1 more reviewer

@DavidKutu DavidKutu DavidKutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rchiodo rchiodo

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rchiodo @codecov-io @IanMatthewHuff @DavidKutu