PublishAllPorts: create port mappings for exposed ports#51586
Merged
Conversation
Signed-off-by: Rob Murray <rob.murray@docker.com>
akerouanton
approved these changes
Nov 25, 2025
corhere
approved these changes
Nov 25, 2025
Member
|
Whoops! Curious; why did it only fail on Windows? |
Contributor
Author
Yeah - it's surprising! I think we'll need to come back to do some tidying. The bridge driver uses Sandbox options to set up the port mappings, they're set up in buildSandboxOptions and it included the ExposedPorts. But Windows uses endpoint options, and they're set up separately in this I've not examined the differences, but it seems likely we're unnecessarily doing stuff twice/differently. |
This was referenced Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
The
-Poption to publish exposed ports doesn't work for Windows containers in 29.x.Before 4239806,
buildPortsRelatedCreateEndpointOptionscreatedportsentries for each ofc.Config.ExposedPorts. So, they were included in the endpoint options ifc.HostConfig.PublishAllPorts.Restore that behaviour.
- How I did it
- How to verify it
Run a Windows container with exposed ports and
-P... check thatdocker psshows the published ports.(Needs an integration test.)
- Human readable description for the release notes