Skip to content

dockerd-rootless-setuptool.sh: fix nsenter: no namespace specified#51622

Merged
vvoland merged 1 commit into
moby:masterfrom
AkihiroSuda:fix-51602
Dec 1, 2025
Merged

dockerd-rootless-setuptool.sh: fix nsenter: no namespace specified#51622
vvoland merged 1 commit into
moby:masterfrom
AkihiroSuda:fix-51602

Conversation

@AkihiroSuda

@AkihiroSuda AkihiroSuda commented Dec 1, 2025

Copy link
Copy Markdown
Member

- What I did

Fix #51602

- How I did it

Corresponds to https://github.com/containerd/nerdctl/blob/v2.2.0/extras/rootless/containerd-rootless-setuptool.sh#L654

- How to verify it

$ dockerd-rootless-setuptool.sh nsenter -- ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host proto kernel_lo 
       valid_lft forever preferred_lft forever
2: tap0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65520 qdisc fq_codel state UP group default qlen 1000
    link/ether 62:ce:d9:92:eb:6b brd ff:ff:ff:ff:ff:ff
    inet 10.0.2.100/24 scope global tap0
       valid_lft forever preferred_lft forever
    inet6 fe80::60ce:d9ff:fe92:eb6b/64 scope link proto kernel_ll 
       valid_lft forever preferred_lft forever
3: br-0c9f8b6e2e31: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default 
    link/ether 9e:66:91:2e:58:70 brd ff:ff:ff:ff:ff:ff
    inet 172.18.0.1/16 brd 172.18.255.255 scope global br-0c9f8b6e2e31
       valid_lft forever preferred_lft forever
    inet6 fc00:f853:ccd:e793::1/64 scope global nodad 
       valid_lft forever preferred_lft forever
4: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default 
    link/ether 3a:50:82:01:3d:7f brd ff:ff:ff:ff:ff:ff
    inet 172.17.0.1/16 brd 172.17.255.255 scope global docker0
       valid_lft forever preferred_lft forever

- Human readable description for the release notes

dockerd-rootless-setuptool.sh: fix `nsenter: no namespace specified`

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah

thaJeztah commented Dec 1, 2025

Copy link
Copy Markdown
Member

Flaky test: #32219 - I kicked CI

=== FAIL: integration-cli TestDockerCLIRestartSuite/TestRestartContainerwithRestartPolicy (49.54s)
    docker_cli_restart_test.go:302: assertion failed: 
        Command:  D:\a\moby\moby\out\docker.exe start ab36cf42931c48da483d5660bd9ee84c2d15f337d0604cde95be6d95c19b352d
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   Error response from daemon: hcsshim::ActivateLayer failed in Win32: The process cannot access the file because it is being used by another process. (0x20)
        Error: failed to start containers: ab36cf42931c48da483d5660bd9ee84c2d15f337d0604cde95be6d95c19b352d
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected no error

=== FAIL: integration-cli TestDockerCLIRestartSuite (88.97s)

thaJeztah
thaJeztah approved these changes Dec 1, 2025
View reviewed changes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread contrib/dockerd-rootless-setuptool.sh
Comment on lines 558 to 560
# main
shift
"cmd_entrypoint_${command}" "$@"

@thaJeztah thaJeztah Dec 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but starting to consider if we should have a "switch" for the commands as well; at least it feels more explicit on intent than the command -v "cmd_entrypoint_${command}" approach.

@thaJeztah thaJeztah added this to the 29.1.2 milestone Dec 1, 2025
@vvoland vvoland merged commit 3964729 into moby:master Dec 1, 2025
300 of 308 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes
@vvoland vvoland vvoland approved these changes

Assignees

No one assigned

Labels

area/contrib area/packaging area/rootless Rootless Mode impact/changelog kind/bugfix PR's that fix bugs

Projects

None yet

Milestone

29.1.2

Development

Successfully merging this pull request may close these issues.

dockerd-rootless-setuptool.sh nsenter: nsenter: no namespace specified

3 participants

@AkihiroSuda @thaJeztah @vvoland