daemon: add "time-namespaces" feature-flag to disable time-namespaces#52577
Conversation
90d67cb to
159d16c
Compare
|
Ah. was somewhat expecting that linter to trigger 😂 |
5d1f4aa to
f212ab1
Compare
|
As in other namespaces, shouldn't this be |
|
With other namespaces this would allow functionality / behavior to be changed; unless I'm mis-informed, with time namespaces there is (currently) none;
With that taken into account, what purpose would such option currently provide? |
|
|
||
| // The "time-namespaces" feature-flag is a (temporary) escape-hatch to disable | ||
| // the use of time-namespaces for containers. This allows users to return to the | ||
| // previous (pre v29.5.0) default, which unconditionally used the host's time-namespace. |
There was a problem hiding this comment.
Can probably remove the version mentioned here (link below should give context)
Add a (temporary) escape-hatch to disable the use of time-namespaces
for containers. This allows users to return to the previous default,
which unconditionally used the host's time-namespace.
With this patch:
dockerd --feature time-namespaces=false
..
INFO[2026-05-07T21:48:40.840255929Z] time-namespaces disabled through feature-override
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
f212ab1 to
24872eb
Compare
|
Updated the comment; I added "validate-only" as it was only a comment change |
|
I'll bring this one in to at least have the escape-hatch, but still interested to learn from Akihiro if there were specific use-cases we've overlooked, w.r.t.;
|
Add a (temporary) escape-hatch to disable the use of time-namespaces for containers. This allows users to return to the previous default, which unconditionally used the host's time-namespace.
With this patch:
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)