Skip to content

Conversation

@mxinden
Copy link
Member

@mxinden mxinden commented Oct 2, 2024

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (eb92e43) to head (111eb32).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   95.35%   95.35%   -0.01%     
==========================================
  Files         112      112              
  Lines       36357    36357              
==========================================
- Hits        34669    34668       -1     
- Misses       1688     1689       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@mxinden mxinden force-pushed the sanitizers branch 9 times, most recently from 32e04f7 to 70ce3dd Compare October 2, 2024 13:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Benchmark results

Performance differences relative to 824d7c4.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [99.567 ns 100.36 ns 101.62 ns]
       change: [-6.1495% -1.6613% +1.0914%] (p = 0.63 > 0.05)

Found 12 outliers among 100 measurements (12.00%)
7 (7.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.69 ns 118.06 ns 118.46 ns]
       change: [-0.2169% +0.3526% +1.0787%] (p = 0.31 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
1 (1.00%) low severe
3 (3.00%) low mild
2 (2.00%) high mild
12 (12.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [117.32 ns 117.81 ns 118.38 ns]
       change: [-0.4720% +0.0290% +0.4595%] (p = 0.90 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
2 (2.00%) low severe
4 (4.00%) low mild
3 (3.00%) high mild
9 (9.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [98.141 ns 98.264 ns 98.413 ns]
       change: [-0.9073% +0.0758% +0.9999%] (p = 0.89 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
3 (3.00%) high mild
6 (6.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.46 ms 111.51 ms 111.57 ms]
       change: [+0.1599% +0.3774% +0.5172%] (p = 0.00 < 0.05)

Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) low mild
2 (2.00%) high mild

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.236 ms 27.356 ms 28.496 ms]
       change: [-3.4256% +1.9111% +7.7430%] (p = 0.51 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.879 ms 37.645 ms 39.398 ms]
       change: [-1.3555% +5.1166% +12.216%] (p = 0.14 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [26.421 ms 27.325 ms 28.253 ms]
       change: [-1.4840% +2.9877% +7.7495%] (p = 0.21 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.997 ms 43.261 ms 45.573 ms]
       change: [-6.6713% +0.5660% +8.0463%] (p = 0.88 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [113.67 ms 114.11 ms 114.53 ms]
       thrpt:  [873.14 MiB/s 876.37 MiB/s 879.75 MiB/s]
change:
       time:   [-0.7823% -0.2431% +0.3108%] (p = 0.40 > 0.05)
       thrpt:  [-0.3099% +0.2437% +0.7885%]

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) low mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [314.85 ms 318.46 ms 322.03 ms]
       thrpt:  [31.053 Kelem/s 31.401 Kelem/s 31.761 Kelem/s]
change:
       time:   [-1.1196% +0.4403% +2.0987%] (p = 0.59 > 0.05)
       thrpt:  [-2.0555% -0.4384% +1.1322%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [33.954 ms 34.178 ms 34.420 ms]
       thrpt:  [29.053  elem/s 29.258  elem/s 29.452  elem/s]
change:
       time:   [-1.1457% -0.3034% +0.5519%] (p = 0.48 > 0.05)
       thrpt:  [-0.5489% +0.3044% +1.1590%]

Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) low mild
5 (5.00%) high mild
3 (3.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 152.5 ± 83.5 92.5 365.2 1.00
neqo msquic reno on 234.5 ± 22.7 206.2 294.5 1.00
neqo msquic reno 218.7 ± 13.7 205.3 243.7 1.00
neqo msquic cubic on 268.6 ± 86.8 208.5 463.7 1.00
neqo msquic cubic 218.2 ± 12.9 205.6 245.1 1.00
msquic neqo reno on 110.1 ± 54.2 80.0 288.9 1.00
msquic neqo reno 143.2 ± 74.2 86.3 327.7 1.00
msquic neqo cubic on 134.3 ± 84.8 82.3 395.3 1.00
msquic neqo cubic 137.2 ± 85.3 82.1 319.0 1.00
neqo neqo reno on 137.7 ± 17.3 120.1 188.0 1.00
neqo neqo reno 244.6 ± 140.9 129.1 603.4 1.00
neqo neqo cubic on 253.4 ± 115.4 135.1 402.0 1.00
neqo neqo cubic 221.1 ± 105.5 124.8 451.0 1.00

⬇️ Download logs

@mxinden mxinden marked this pull request as ready for review October 2, 2024 17:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Copy link
Collaborator

@larseggert larseggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Lars Eggert <lars@eggert.org>
Signed-off-by: Max Inden <mail@max-inden.de>
@larseggert larseggert added this pull request to the merge queue Oct 3, 2024
@larseggert larseggert removed this pull request from the merge queue due to a manual request Oct 3, 2024
@larseggert larseggert added this pull request to the merge queue Oct 3, 2024
Merged via the queue into mozilla:main with commit 4e75a77 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants