KV TTL (stream max_age) versus stream duplicate_window #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Apr 9, 2025
| String name; | ||
| StreamConfiguration.Builder scBuilder; | ||
| protected String name; | ||
| protected Duration ttl = Duration.ZERO; |
Contributor
Author
There was a problem hiding this comment.
added this do I can track it easier at the build() stage
MauriceVanVeen
approved these changes
Apr 9, 2025
Member
MauriceVanVeen
left a comment
There was a problem hiding this comment.
LGTM, one small comment
| if (ttlMs > 0 && ttlMs < SERVER_DEFAULT_DUPLICATE_WINDOW_MS) { | ||
| dupeMs = ttlMs; | ||
| } | ||
| scBuilder.duplicateWindow(dupeMs).build(); |
Member
There was a problem hiding this comment.
I think this .build() could be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that duplicate window is