Merged
Conversation
Accept a per message ttl when creating a kv.
scottf
commented
Apr 30, 2025
|
|
||
| /** | ||
| * The time delete marker TTL duration. Server accepts 1 second or more. | ||
| * CLIENT DOES NOT VALIDATE |
Contributor
Author
There was a problem hiding this comment.
Changed my mind to now validate.
scottf
commented
Apr 30, 2025
| * @param subjectDeleteMarkerTtlMillis the TTL duration | ||
| * @return The Builder | ||
| */ | ||
| public Builder subjectDeleteMarkerTtl(long subjectDeleteMarkerTtlMillis) { |
Contributor
Author
There was a problem hiding this comment.
didn't originally have the ms api complement to the duration api
scottf
commented
Apr 30, 2025
| private long firstSequence = 1; | ||
| private boolean allowMessageTtl = false; | ||
| private Duration subjectDeleteMarkerTtl = Duration.ZERO; | ||
| private Duration subjectDeleteMarkerTtl; |
Contributor
Author
There was a problem hiding this comment.
null is better and the getter already noted could be null
MauriceVanVeen
approved these changes
Apr 30, 2025
Member
MauriceVanVeen
left a comment
There was a problem hiding this comment.
LGTM, one minor comment
| * @return The Builder | ||
| */ | ||
| public static MessageTtl seconds(int msgTtlSeconds) { | ||
| if (msgTtlSeconds < 0) { |
Member
There was a problem hiding this comment.
Should this be msgTtlSeconds < 1 instead (or <= 0)?
Contributor
Author
There was a problem hiding this comment.
yeah, I need to fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept a per message ttl when creating a kv. Implements ADR-43