Skip to content

Conversation

@scottf
Copy link
Contributor

@scottf scottf commented Jul 29, 2025

StreamName was annotated as @NonNull

@NonNull
public String getName() {
    return name;
}

This is actually correct, but under the covers...

  • The builder allowed null but this was handled in JetStreamManagement when adding or updating a stream, the name was valdiate. This has been moved to the builder. Same type of exception and same message, so is backward compatible, and should have no practical issues for users, since it's still the same error, just on build(...) instead of addStream or updateStream, which is called with a built StreamConfiguration.
  • The StreamInfo creation always read the "config" field from an incoming response to getStreamInfo(). This was a problem because if the request was an error, there is no StreamConfiguration in the response. So this is fixed by checking the field first.

Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 7513114 into main Jul 31, 2025
5 of 6 checks passed
@scottf scottf deleted the stream-name-not-null branch July 31, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants