Header nullability #1395
Header nullability #1395
Conversation
| t = System.nanoTime() - t; | ||
| System.out.println("Time: " + t / 1000 / 1000.0 +"ms, Op/sec: "+(max*1_000_000_000L/t)); | ||
| } | ||
| // @Test |
There was a problem hiding this comment.
Can the commented out code be removed?
| go-version: '1.21.4' | ||
| - name: Install Nats Server | ||
| run: | | ||
| pkill -9 nats-server 2>/dev/null || true |
There was a problem hiding this comment.
I originally thought the problem was servers were being left around, and had been meaning to add this anyway.
| cp main ~/.local/bin/nats-server | ||
| cd .. | ||
| rm -rf nats-server | ||
| git checkout tags/v2.11.8 -b release |
There was a problem hiding this comment.
Right now I need to run against 2.11.8 instead of head of main. Really need to figure out how to just get the latest release. The scripts in use elsewhere are unreliable.
| cd .. | ||
| rm -rf nats-server | ||
| git checkout tags/v2.11.8 -b release | ||
| go build -o ~/.local/bin/nats-server |
There was a problem hiding this comment.
Reflects not from Neil on simplifying the building and placing the nats-server
|
|
||
| ```bash | ||
| nats-server --conf src/test/resources/tls.conf | ||
| nats-server --config src/test/resources/tls.conf |
There was a problem hiding this comment.
This had been wrong a long time.
| private final Map<String, Integer> lengthMap; | ||
| private final boolean readOnly; | ||
| private byte @Nullable [] serialized; | ||
| private byte[] serialized; |
There was a problem hiding this comment.
The Nullable was added from a user's PR but is not really necessary.
| * @param dest the byte array to write to | ||
| * @return the length of the header | ||
| */ | ||
| @SuppressWarnings("deprecation") |
There was a problem hiding this comment.
I moved this to comments closer to the lines of code.
| private void assertKeyIgnoreCaseContainsValues(Headers headers, List<String> keys, List<String> values) { | ||
| for (String k : keys) { | ||
| List<String> hVals = headers.getIgnoreCase(k); | ||
| assertNotNull(hVals); |
There was a problem hiding this comment.
pretty much all of the test changes where to check for null as the new annotation shows up with warnings from IntelliJ
No description provided.