Conversation
MauriceVanVeen
approved these changes
Oct 1, 2025
| uses: actions/checkout@v4 | ||
| - name: Build and Test | ||
| run: chmod +x gradlew && ./gradlew clean test jacocoTestReport coveralls | ||
| # run: chmod +x gradlew && ./gradlew --refresh-dependencies clean test jacocoTestReport coveralls |
| id 'maven-publish' | ||
| id 'jacoco' | ||
| id 'com.github.kt3k.coveralls' version '2.12.0' | ||
| // id 'com.github.kt3k.coveralls' version '2.12.2' |
Contributor
Author
There was a problem hiding this comment.
it's left in as a reminder that I need to replace it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was reported that the just disconnected server was the first server to attempt to be connected to after a disconnect. Even though the server had been put at the end of the pool when it was connected, discovery of servers randomized the list, making it possible to have been put in the first spot.
This is fixed when there is a disconnection. When a disconnection occurs the server pool is now told that the current server connection has "failed". Telling the pool that the server connection failed used to only happen during the connect or reconnect process and discovery after connection would shuffle the list.
Now on disconnection, we tell the pool that the server failed. On this "failed" function call, the pool used to just mark the server as a fail. But now it also moves it to the end of the list, just in case it had been shuffled to the top.