Improve output queue push locking and error message#1446
Merged
Conversation
Contributor
scottf
commented
Oct 3, 2025
- More meaningful error message.
- Tuning locking
* More meaningful error message. * Tuning locking
scottf
commented
Oct 3, 2025
| } | ||
|
|
||
| lockWasSuccessful = true; | ||
| if (editLock.tryLock(offerLockNanos, TimeUnit.NANOSECONDS)) { |
Contributor
Author
There was a problem hiding this comment.
Remove the need to track whether the lock was obtained manually. Just simpler.
MauriceVanVeen
approved these changes
Oct 6, 2025
|
|
||
| // The trailing space is intentional as in "Output queue is full 5000" | ||
| String OUTPUT_QUEUE_IS_FULL = "Output queue is full "; | ||
| String OUTPUT_QUEUE_BUSY = "Output queue is busy "; |
Member
There was a problem hiding this comment.
This value doesn't seem to be used in MessageQueue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.