Auth Error is allowed to be set before being connected#1475
Merged
Conversation
scottf
commented
Nov 7, 2025
| // If we are connected && we get an authentication error, save it | ||
| if (this.isConnected() && this.isAuthenticationError(errorText) && currentServer != null) { | ||
| // If we get an authentication error, save it | ||
| if (this.isAuthenticationError(errorText) && currentServer != null) { |
Contributor
Author
There was a problem hiding this comment.
This can happen on any login where the credentials are wrong
scottf
commented
Nov 7, 2025
| jsServer.close(); | ||
| if (jsServer != null) { | ||
| jsServer.close(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is just a code guard
scottf
commented
Nov 7, 2025
| try (NatsTestServer ts = new NatsTestServer( | ||
| NatsTestServer.builder() | ||
| .configFilePath("src/test/resources/tls_first.conf") | ||
| .connectValidateTlsFirstMode()) |
Contributor
Author
There was a problem hiding this comment.
The newest server runner validates connection in a different way, so it needs to know when it's tls first.
scottf
commented
Nov 7, 2025
| .connectValidateInitialDelay(100L) | ||
| .connectValidateSubsequentDelay(25L) | ||
| .connectValidateTries(15) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
I want the long running server to have plenty of time to start up.
scottf
commented
Nov 7, 2025
| .maxReconnects(0) | ||
| .errorListener(new ErrorListener() {}) | ||
| .token("notthetoken".toCharArray()) | ||
| .build(); |
Contributor
Author
There was a problem hiding this comment.
This was the test that was flapping/failing
scottf
commented
Nov 7, 2025
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package io.nats.client; |
Contributor
Author
There was a problem hiding this comment.
I have no idea why the diff is so large here, not that much was changed
scottf
commented
Nov 7, 2025
| NatsServerRunner.setDefaultValidateTries(5); | ||
| NatsServerRunner.setDefaultInitialValidateDelay(100); | ||
| NatsServerRunner.setDefaultSubsequentValidateDelay(50); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This static block is the only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.