Enable path component when connecting via WebSocket#1514
Merged
scottf merged 3 commits intonats-io:mainfrom Jan 12, 2026
Merged
Enable path component when connecting via WebSocket#1514scottf merged 3 commits intonats-io:mainfrom
scottf merged 3 commits intonats-io:mainfrom
Conversation
Contributor
|
@jbaeck For the test, we would have to mock a proxy of some sort? For now, as long as all the websocket tests pass confirming nothing is broken, and you manually confirm via a comment that you have tested your new pathways, I can live with that. |
Author
|
@scottf - all manual tests against my environment worked as well as the existing Tests. Anything else I could look into ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a WebSocket connection url is specfied via ws://HOST:IP/PATH the PATH will now be included when establishing the connection.
I need help implementing a Test as I have not found a way to define the path in the nats websocket configuration.