Auto-port 4.1: Fix HTTP 2 PUSH_PROMISE stream association validation#16955
Merged
Conversation
Motivation: `DefaultHttp2FrameReader` did not verify that `PUSH_PROMISE` frames are associated with a stream before processing the frame-specific payload. As a result, a `PUSH_PROMISE` frame with stream ID `0` was not rejected by the same stream association validation used by DATA, HEADERS, PRIORITY, and RST_STREAM frames. Per RFC 9113 section 6.6, `PUSH_PROMISE` frames identify the stream they are associated with, and receipt of a `PUSH_PROMISE` frame with stream ID `0` MUST be treated as a connection error of type `PROTOCOL_ERROR`. Modifications: - Add `verifyAssociatedWithAStream()` to `verifyPushPromiseFrame()`. - Add a regression test for `PUSH_PROMISE` with stream ID `0`. - Verify that the error is connection-level `PROTOCOL_ERROR`. - Verify that `onPushPromiseRead(...)` is not invoked for the invalid frame. Result: Invalid `PUSH_PROMISE` frames with stream ID `0` are now rejected consistently with other stream-associated HTTP/2 frame types. (cherry picked from commit 6dabf56)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #16952 to 4.1
Cherry-picked commit: 6dabf56
Motivation:
DefaultHttp2FrameReaderdid not verify thatPUSH_PROMISEframes are associatedwith a stream before processing the frame-specific payload. As a result, a
PUSH_PROMISEframe with stream ID0was not rejected by the same streamassociation validation used by DATA, HEADERS, PRIORITY, and RST_STREAM frames.
Per RFC 9113 section 6.6,
PUSH_PROMISEframes identify the stream they areassociated with, and receipt of a
PUSH_PROMISEframe with stream ID0MUST betreated as a connection error of type
PROTOCOL_ERROR.Modifications:
verifyAssociatedWithAStream()toverifyPushPromiseFrame().PUSH_PROMISEwith stream ID0.PROTOCOL_ERROR.onPushPromiseRead(...)is not invoked for the invalid frame.Result:
Invalid
PUSH_PROMISEframes with stream ID0are now rejected consistentlywith other stream-associated HTTP/2 frame types.