test: consume bodies of fetch responses to fix failing macos 20 ci #4528
Merged
test: consume bodies of fetch responses to fix failing macos 20 ci #4528
Conversation
9b8476b to
04081e9
Compare
b3a6a92 to
234c00f
Compare
e665be5 to
fb9e3bf
Compare
f9a8dd1 to
33f7fb4
Compare
c3803fe to
f4cc9a5
Compare
Contributor
Author
|
@metcoder95 Can one of you please approve? I think this time it should fix those files finally... |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consuming the bodies ensures that the tests will not fail. Plus removing tspl in encoding.js as it seems to make issues...
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status