Summary

Fixes #4628

When a WebSocket is closed before the connection is established, the error and close events were being fired twice instead of once.

Root Cause

The issue was caused by onSocketClose() being called multiple times:

1. First call: When ws.close() is called before connection, it triggers:
   • closeWebSocketConnection → failWebsocketConnection → onSocketClose()
2. Second call: The aborted fetch controller returns an error response, which triggers:
   • failWebsocketConnection again → onSocketClose() again

Solution

Added a closeEventFired flag to the WebSocket handler to prevent duplicate events from being fired.

Changes

• lib/web/websocket/websocket.js:

  • Added closeEventFired property to the Handler typedef
  • Initialized closeEventFired: false in the handler object
  • Added early return check in #onSocketClose() to prevent duplicate events

• test/websocket/issue-4628.js:

  • Added regression test to verify events fire exactly once

Testing

• ✅ New test case passes
• ✅ All existing websocket tests pass (85 tests)
• ✅ Manual verification with reproduction case from issue

Before Fix

error 3
Closed 3
error 3
Closed 3

After Fix

error 3
Closed 3

🤖 Generated with Claude Code