Skip to content

fix websocketstream open error#4748

Merged
mcollina merged 2 commits intonodejs:mainfrom
KhafraDev:websocketstream-closinginfo
Jan 21, 2026
Merged

fix websocketstream open error#4748
mcollina merged 2 commits intonodejs:mainfrom
KhafraDev:websocketstream-closinginfo

Conversation

@KhafraDev
Copy link
Member

fixes #4732
closes #4733

Co-authored-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (3388513) to head (95941a3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4748      +/-   ##
==========================================
+ Coverage   92.94%   93.23%   +0.28%     
==========================================
  Files         109      109              
  Lines       33981    33982       +1     
==========================================
+ Hits        31584    31682      +98     
+ Misses       2397     2300      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 761fce9 into nodejs:main Jan 21, 2026
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebSocketStream throws internal error when cannot open an connection

3 participants