fix: use commit hash when generating release (#4757)#4759
Merged
mcollina merged 1 commit intonodejs:mainfrom Jan 22, 2026
Merged
fix: use commit hash when generating release (#4757)#4759mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4759 +/- ##
=======================================
Coverage 93.22% 93.23%
=======================================
Files 109 109
Lines 34024 34024
=======================================
+ Hits 31720 31721 +1
+ Misses 2304 2303 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
#4757
Rationale
By using the commit hash there is no longer a race condition that could result in the GitHub tag/release being applied to a different commit than was published to NPM.
Changes
Passed the commit hash that triggered the workflow to release scripts so that the commit hash can be used instead of the branch to create the release and release notes.
Features
N/A
Bug Fixes
#4757
Breaking Changes and Deprecations
No
Status