feat(nuxt): enable preloading object-syntax routes#19120
Merged
danielroe merged 5 commits intoMar 6, 2023
Conversation
|
|
danielroe
reviewed
Feb 17, 2023
7 tasks
Member
|
Would you update this following the merge of your other PR? 🙏 |
# Conflicts: # packages/nuxt/src/app/components/nuxt-link.ts
Member
Author
|
Thank you for bringing this to my attention. I resolved the conflict caused by #19144. |
Member
Author
|
I'm unsure which option is better between using Does the Overall, this issue is not significant because although dynamic routing repeats preloading, it doesn't require sending additional network requests. |
Member
|
|
preloadRouteComponents to accept RouteLocationRaw values
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
preloadRouteComponentsallows passing values of typeRouteLocationRaw#18845❓ Type of change
📚 Description
After this PR, the path parsed by the following code all will be
/home. As a result, the preload function will not retry and will instead return early.In addition, when users use
preloadRouteComponents, they are not limited to type string.📝 Checklist