feat(nuxt): enable config schema by default#19172
Conversation
|
|
atinux
left a comment
There was a problem hiding this comment.
Looks good to me at first sight, will have to try with nuxt-edge to see if it works properly on nuxt-icon for instance.
|
Apologies for delay in reviewing properly. (Very much looking forward to this landing - and it does look great!) I'm planning to merge this in for v3.3 release (so ideally 1 Mar merge directly after patch release, then a week of testing on edge). Does that work for you @atinux? |
|
@danielroe I think we should start thinking of semver/patch release branches this way we have more time for edge testing not blocked by patches :) |
|
If you need more time to test, we can release the changes in next patch as long as we preserve default flag value as |
|
No i need to test the default behavior via edge channel on main branch :) Patch shouldn't be blocker will continue this on discord later today. |
|
Disabled flag for now to land into edge/patch without being blocked. Checking (more generic) non blocker edge feat testing next week 👍🏼 |
| await nuxt.hooks.callHook('schema:beforeWrite', schema) | ||
| await writeSchema(schema) | ||
| await nuxt.hooks.callHook('schema:written') |
There was a problem hiding this comment.
would it make sense to move the hooks into writeSchema itself?
🔗 Linked issue
#15592
❓ Type of change
📚 Description
Changes:
nuxt prepare.nuxt/schemadirectory to avoid confusion and removal_AppConfigto allow merging📝 Checklist