fix(nuxt): improve types for data fetching with transform#19487
Merged
Conversation
|
|
danielroe
reviewed
Mar 6, 2023
danielroe
left a comment
Member
There was a problem hiding this comment.
This looks really nice, thank you! ❤️
Do you think there is a way we can keep this from being a breaking change, e.g. by using a function signature overload?
Merged
danielroe
approved these changes
Mar 11, 2023
transform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #14437
❓ Type of change
📚 Description
Current
AsyncDataOptionsis not able to infer correct type ondefaultoption whentransformexists, this pr fixes the issue and also improve type inference on composablesuseAsyncData/useLazyAsyncData/useFetch/useLazyFetchby inferring transformed data instead of transform function.👉 Migration
No migration is needed if you are only using the first generic of
useFetchoruseAsyncData. But if you were typing more fields, or trying to clone the Nuxt types, you will need to update your types to use (instead of a type for the transform function, you will provide a type for the return value of the transform function).This will probably not affect you as the types were buggy in this case (which was what this PR was solving).
📝 Checklist