Skip to content

feat(nuxt): support custom keyed composables#19490

Merged
danielroe merged 4 commits into
mainfrom
feat/custom-keyed-composables
Mar 7, 2023
Merged

feat(nuxt): support custom keyed composables#19490
danielroe merged 4 commits into
mainfrom
feat/custom-keyed-composables

Conversation

@danielroe

@danielroe danielroe commented Mar 6, 2023

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #12369

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds support for creating custom keyed composables. Keys will be injected as a final argument as long as the number of arguments is less than the maximum argumentLength.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the ✨ enhancement New feature or improvement to existing functionality label Mar 6, 2023
@danielroe danielroe self-assigned this Mar 6, 2023
@codesandbox

codesandbox Bot commented Mar 6, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added 3.x 🍰 p2-nice-to-have Nice to have, not blocking labels Mar 6, 2023
@danielroe danielroe marked this pull request as ready for review March 6, 2023 22:35
@danielroe danielroe requested review from harlan-zw and pi0 March 6, 2023 22:35

@TheAlexLichter TheAlexLichter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only docs are missing 😋

@danielroe danielroe merged commit 60d07df into main Mar 7, 2023
@danielroe danielroe deleted the feat/custom-keyed-composables branch March 7, 2023 21:06
@danielroe danielroe mentioned this pull request Mar 8, 2023
@zhuoqi-chen

Copy link
Copy Markdown

I really need this feature, especially for the composable function which wrapper the useAsyncData . THX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x ✨ enhancement New feature or improvement to existing functionality 🍰 p2-nice-to-have Nice to have, not blocking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to add your own keyed functions

4 participants