Skip to content

perf(vite): mark more core functions as side-effect free#19508

Merged
danielroe merged 2 commits into
mainfrom
perf/further-side-effects
Mar 7, 2023
Merged

perf(vite): mark more core functions as side-effect free#19508
danielroe merged 2 commits into
mainfrom
perf/further-side-effects

Conversation

@danielroe

@danielroe danielroe commented Mar 7, 2023

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This reduces our bundle size when not using certain features of Nuxt, such as app config, runtime config, etc. It's a minimal amount but worth it. 🏋️‍♂️

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added ✨ enhancement New feature or improvement to existing functionality 3.x bundler:vite Vite bundler integration ⚡ performance Performance degradation or optimization opportunity labels Mar 7, 2023
@danielroe danielroe self-assigned this Mar 7, 2023
@danielroe danielroe requested a review from antfu March 7, 2023 16:05
@codesandbox

codesandbox Bot commented Mar 7, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe merged commit c2ab76d into main Mar 7, 2023
@danielroe danielroe deleted the perf/further-side-effects branch March 7, 2023 22:51
@danielroe danielroe mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x bundler:vite Vite bundler integration ✨ enhancement New feature or improvement to existing functionality ⚡ performance Performance degradation or optimization opportunity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants