Skip to content

perf(nuxt): tree-shake server composables + prefer server head#19576

Merged
danielroe merged 2 commits into
mainfrom
perf/minor-head-optimisations
Mar 10, 2023
Merged

perf(nuxt): tree-shake server composables + prefer server head#19576
danielroe merged 2 commits into
mainfrom
perf/minor-head-optimisations

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Mar 10, 2023

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Some minor head optimisations that didn't fit in the other PRs:

  • Adding the server composables to the new tree shake config.
  • Using the createServerHead instead of createHead, this avoids bundling the @unhead/dom package server side

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandbox Bot commented Mar 10, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe added ✨ enhancement New feature or improvement to existing functionality 3.x ⚡ performance Performance degradation or optimization opportunity labels Mar 10, 2023
@danielroe

danielroe commented Mar 10, 2023

Copy link
Copy Markdown
Member

This looks good but I think @unhead/dom is still present in the server node_modules.

@harlan-zw

harlan-zw commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

This looks good but I think @unhead/dom is still present in the server node_modules.

Hmm thanks, will investigate 🤔

@danielroe danielroe changed the title perf(head): tree-shake server composables, prefer server head perf(nuxt): tree-shake server composables + prefer server head Mar 10, 2023
@danielroe danielroe merged commit d2f0b22 into main Mar 10, 2023
@danielroe danielroe deleted the perf/minor-head-optimisations branch March 10, 2023 16:45
@danielroe danielroe mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

3.x ✨ enhancement New feature or improvement to existing functionality ⚡ performance Performance degradation or optimization opportunity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harlan-zw @danielroe