Skip to content

fix(nuxt): mark non-augmented NuxtApp properties as unknown#19643

Merged
danielroe merged 3 commits into
mainfrom
fix/nuxtapp-signature
Mar 14, 2023
Merged

fix(nuxt): mark non-augmented NuxtApp properties as unknown#19643
danielroe merged 3 commits into
mainfrom
fix/nuxtapp-signature

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #14495

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds more typings for internal NuxtApp properties, primarily for our own internal use. None of the properties marked as @internal should be relied on by end users.

It also updates the default typing of unknown properties on NuxtApp to unknown meaning it will properly respect end users' strictness settings and flag issues when the type is missing (for example, if a provided property is renamed).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added ✨ enhancement New feature or improvement to existing functionality 3.x 🐛 bug Something isn't working as expected labels Mar 13, 2023
@danielroe danielroe requested review from antfu and pi0 March 13, 2023 12:58
@danielroe danielroe self-assigned this Mar 13, 2023
@codesandbox

codesandbox Bot commented Mar 13, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe removed their assignment Mar 13, 2023
@danielroe danielroe merged commit 0f6276d into main Mar 14, 2023
@danielroe danielroe deleted the fix/nuxtapp-signature branch March 14, 2023 10:09
@danielroe danielroe mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x 🐛 bug Something isn't working as expected ✨ enhancement New feature or improvement to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

better typings for useNuxtApp

1 participant