Skip to content

Separate the infer_shapes option from the check_model option #6441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinchuby merged 1 commit into from
Oct 9, 2024
Merged

Separate the infer_shapes option from the check_model option #6441

justinchuby merged 1 commit into from
Oct 9, 2024

Conversation

@tonypottera24
Copy link
Contributor

@tonypottera24 tonypottera24 commented Oct 9, 2024

Description

Separate the infer_shapes option from the check_model option.
Whether to infer_shapes or not should be controlled independently.

Motivation and Context

The check_model check was applied to infer_shapes in #6344.
However, for some use cases like issue #6368, infer_shapes is necessary but it cannot pass check_model because the output node shape is missing.

Adding an empty dimension like PR #6437 doesn't work since onnxruntime.InferenceSession treats an empty dimension as a dimension.

@tonypottera24
add option infer-shapes
fefa641 
Signed-off-by: Po-Chu Hsu <tonypottera@gmail.com>
@tonypottera24 tonypottera24 requested a review from a team as a code owner October 9, 2024 10:08
@codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.25%. Comparing base (d7fbf2b) to head (fefa641).
Report is 315 commits behind head on main.

Files with missing lines Patch % Lines
onnx/utils.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6441   +/-   ##
=======================================
  Coverage   57.25%   57.25%           
=======================================
  Files         507      507           
  Lines       31433    31433           
  Branches     4690     4690           
=======================================
  Hits        17997    17997           
  Misses      12581    12581           
  Partials      855      855

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonypottera24 tonypottera24 mentioned this pull request Oct 9, 2024
Closed
@justinchuby justinchuby added this pull request to the merge queue Oct 9, 2024
Merged via the queue into onnx:main with commit 63ba6a1 Oct 9, 2024
@tonypottera24 tonypottera24 deleted the infer_shapes-patch branch October 10, 2024 00:06
@ramkrishna2910 ramkrishna2910 added the module: checker onnx.checker label May 12, 2025
@botantony botantony mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees

No one assigned

Labels

module: checker onnx.checker

Projects

PR Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonypottera24 @justinchuby @ramkrishna2910