Improve pyproject.toml and add py.typed #6843
Merged
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyy <cyyever@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6843 +/- ##
=======================================
Coverage 56.28% 56.28%
=======================================
Files 509 509
Lines 32580 32580
Branches 3099 3099
=======================================
Hits 18337 18337
Misses 13385 13385
Partials 858 858 ☔ View full report in Codecov by Sentry. |
Member
transformer? |
Contributor
Author
|
typo |
andife
reviewed
Mar 30, 2025
justinchuby
reviewed
Mar 30, 2025
Signed-off-by: cyy <cyyever@outlook.com>
Contributor
Author
|
@justinchuby isort is also removed. |
Member
|
Also interesting, then the analysis mentioned in #6710 was wrong, because there py.typed was detected |
justinchuby
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
py.typed is a marker file to support typing. See pep 561. It's used to indicate that ONNX has typing support in the source code and tools such as mypy and pylint can take advantage of that. Therefore, we don't need an additional pyi file for typing.
Motivation and Context
Better code.