-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Allow conversion from OpSchema to OpSchemaRegisterOnce #7390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7390 +/- ##
=======================================
Coverage 54.45% 54.45%
=======================================
Files 511 511
Lines 31876 31876
Branches 2868 2868
=======================================
Hits 17359 17359
Misses 13734 13734
Partials 783 783 ☔ View full report in Codecov by Sentry. |
fad2547 to
ff54e8d
Compare
|
Can we have a test for this? |
|
@justinchuby Sadly it is not covered. I cannot conceive an OpSchema for the unit test, any idea? |
|
Do you mean you need a way to create a custom schema? |
|
@justinchuby Yes, do you have an example? |
|
I think is can be a good example: https://github.com/microsoft/onnxruntime/blob/f0015b956723ec98efa8292a0628f99a5b6e8b3d/onnxruntime/core/session/environment.cc#L332-L342 |
|
A case has been added to CMake test. |
89da743 to
d17b5bc
Compare
7199536 to
859aaa9
Compare
|
Updating the branch and enable auto-merge |
|
Some CIs won't run. |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
|
@titaiwangms There was a syntactic error in |
Description
This PR contains the below changes:
explicitdecoration from classOpSchemaRegisterOnce.OpSchemaRegisterOnce, and that there is no easy way to selectively export these symbols, we have to export all protobuf symbols.Motivation and Context
To keep backward compatibility.