remove ByteBuffer duplicate

trask · trask · commit 99bb2f138856 · 2026-01-26T19:30:15.000-08:00
diff --git a/api/all/src/main/java/io/opentelemetry/api/common/JsonEncoding.java b/api/all/src/main/java/io/opentelemetry/api/common/JsonEncoding.java
@@ -99,7 +99,7 @@ private static void appendDouble(StringBuilder sb, double value) {
 
   private static void appendBytes(StringBuilder sb, ByteBuffer value) {
     byte[] bytes = new byte[value.remaining()];
-    value.duplicate().get(bytes);
+    value.get(bytes);
     sb.append('"').append(Base64.getEncoder().encodeToString(bytes)).append('"');
   }
 

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ private static void appendDouble(StringBuilder sb, double value) {`
`99`	`99`
`100`	`100`	`private static void appendBytes(StringBuilder sb, ByteBuffer value) {`
`101`	`101`	`byte[] bytes = new byte[value.remaining()];`
`102`		`- value.duplicate().get(bytes);`
	`102`	`+ value.get(bytes);`
`103`	`103`	`sb.append('"').append(Base64.getEncoder().encodeToString(bytes)).append('"');`
`104`	`104`	`}`
`105`	`105`