Add file configuration ComponentProvider support for resources#6625
Merged
jack-berg merged 3 commits intoopen-telemetry:mainfrom Aug 28, 2024
Merged
Add file configuration ComponentProvider support for resources#6625jack-berg merged 3 commits intoopen-telemetry:mainfrom
jack-berg merged 3 commits intoopen-telemetry:mainfrom
Conversation
6 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6625 +/- ##
=========================================
Coverage 90.18% 90.18%
- Complexity 6259 6267 +8
=========================================
Files 697 697
Lines 18871 18901 +30
Branches 1843 1847 +4
=========================================
+ Hits 17018 17046 +28
- Misses 1282 1285 +3
+ Partials 571 570 -1 ☔ View full report in Codecov by Sentry. |
…y-java into resource-component-provider
trask
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6574.
In the issue, I said this about resources:
I had a change of heart in the implementation. Implementations of ResourceProvider expect to be participating in a configuration scenario which is based on the env var / system property configuration scheme. They receive a ConfigProperties instead of the StructuredConfigProperties used in file config, and look for things in it like
otel.resource.attributesandotel.service.nameto influence their behavior.Instead, in this PR I use
ComponentProviderto provide resource attributes. This will require me to go and update the various resource provider artifacts and implementComponentProvider, but will be more precise, and more consistent with the clean separation approach we've been taking with file configuration.