prom exporter: exclude shaded protobuf#7355
Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom Jun 5, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7355 +/- ##
============================================
- Coverage 89.87% 89.76% -0.11%
- Complexity 6899 6978 +79
============================================
Files 786 797 +11
Lines 20793 21165 +372
Branches 2026 2056 +30
============================================
+ Hits 18687 18999 +312
- Misses 1465 1504 +39
- Partials 641 662 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@jack-berg can you take a look? |
jack-berg
reviewed
Jun 5, 2025
| implementation("io.prometheus:prometheus-metrics-exporter-httpserver") { | ||
| exclude(group = "io.prometheus", module = "prometheus-metrics-exposition-formats") | ||
| } | ||
| implementation("io.prometheus:prometheus-metrics-exposition-formats-no-protobuf") |
Member
There was a problem hiding this comment.
We can get away with io.prometheus:prometheus-metrics-exposition-textformats, and adding io.prometheus:prometheus-metrics-exposition-formats-no-protobuf as a testImplementation dependency. Pushing a commit to do this so we can get this in for tomorrow's release!
jack-berg
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://prometheus.github.io/client_java/exporters/formats/#exclude-the-shaded-protobuf-classes
runtime classpath