fix: validate command to exit with non-zero status on errors#485
Merged
rhamzeh merged 5 commits intoopenfga:mainfrom Apr 21, 2025
Siddhant-K-code:fix/484
Merged
fix: validate command to exit with non-zero status on errors#485rhamzeh merged 5 commits intoopenfga:mainfrom Siddhant-K-code:fix/484
rhamzeh merged 5 commits intoopenfga:mainfrom
Siddhant-K-code:fix/484
Conversation
This was referenced Apr 19, 2025
rhamzeh
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
fga model validatecommand to properly exit with a non-zero status code when validation fails, making it more useful in CI/CD pipelines and build tools like Bazel.Also fixed some linting issues related to function ordering in the codebase.
References
fixes #484
Review Checklist
main