Skip to content

Conversation

@iignatev
Copy link
Member

@iignatev iignatev commented Sep 6, 2020

pre-skara ear RFR threads: Aug, Sep

Hi all,

could you please review this small patch which updates StressOptions to adjust allocated time according to TIMEOUT_FACTOR?

from JBS:

nsk/share/test/StressOptions and Stresser aren't aware of jtreg's timeout-factor and hence don't provide enough stress time for testing in slow/stress configurations, e.g. Xcomp.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252522: nsk/share/test/StressOptions should multiple stressTime by jtreg's timeout-factor

Reviewers

  • dholmes - Reviewer ⚠️ Added manually

Download

$ git fetch https://git.openjdk.java.net/jdk pull/32/head:pull/32
$ git checkout pull/32

@iignatev iignatev marked this pull request as ready for review September 6, 2020 16:09
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2020

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2020
@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

@iignatev
Copy link
Member Author

iignatev commented Sep 6, 2020

/label add hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 6, 2020
@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev
The hotspot label was successfully added.

@iignatev
Copy link
Member Author

iignatev commented Sep 6, 2020

/reviewer add dholmes

@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev Syntax: /reviewer (add|remove) [@user | openjdk-user]+. For example:

  • /reviewer add @openjdk-bot
  • /reviewer add duke
  • /reviewer add @user1 @user2

@iignatev
Copy link
Member Author

iignatev commented Sep 6, 2020

/reviewer add dholmes

@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev
Reviewer dholmes successfully added.

@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252522: nsk/share/test/StressOptions should multiple stressTime by jtreg's timeout-factor

Reviewed-by: dholmes
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 1262ae3: 8252679: Two windows specific FileDIalog tests may fail on some Windows_Server_2016_Standard
  • d0f4366: 8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 1262ae36af0c9a41609765966123751b5ad9098b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2020
@iignatev
Copy link
Member Author

iignatev commented Sep 6, 2020

/integrate

@openjdk openjdk bot closed this Sep 6, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 6, 2020
@openjdk
Copy link

openjdk bot commented Sep 6, 2020

@iignatev Since your change was applied there have been 2 commits pushed to the master branch:

  • 1262ae3: 8252679: Two windows specific FileDIalog tests may fail on some Windows_Server_2016_Standard
  • d0f4366: 8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux

Your commit was automatically rebased without conflicts.

Pushed as commit 5f76deb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 6, 2020
@iignatev iignatev deleted the 8252522 branch September 6, 2020 16:18
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant