Skip to content

chore: bump version in MSI installer.wxs#3400

Merged
airween merged 2 commits into
owasp-modsecurity:v2/masterfrom
airween:v2/msiinstaller
Jun 11, 2025
Merged

chore: bump version in MSI installer.wxs#3400
airween merged 2 commits into
owasp-modsecurity:v2/masterfrom
airween:v2/msiinstaller

Conversation

@airween

@airween airween commented Jun 10, 2025

Copy link
Copy Markdown
Member

what

This PR sets the correct version string in MSI installer file.

why

There is a user report about the wrong version string.

references

See #3399 for the report.

@airween airween requested review from fzipi and theseion June 10, 2025 08:57
fzipi
fzipi approved these changes Jun 10, 2025
View reviewed changes

@fzipi fzipi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be cleaned up. There is a lot of commented stuff (e.g. old crs versions). Also, do you know which pcre version is used by default in the windows build? It should be using the newer version also, right?

Comment thread iis/installer.wxs Outdated
@airween @fzipi
Typo fix
8fd8f37 
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 10, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@airween

airween commented Jun 10, 2025

Copy link
Copy Markdown
Member Author

This file should be cleaned up.

Yes, definitely, it should.

There is a lot of commented stuff (e.g. old crs versions). Also, do you know which pcre version is used by default in the windows build? It should be using the newer version also, right?

I have no idea. Unfortunately, I don't have any Windows and can't check the build flow. I know this is a big problem, because there is another Windows related issue (#3397). But for that (and for this too) we need not just a Windows, but an IIS too.

@airween airween requested a review from fzipi June 10, 2025 14:14
@airween airween requested review from theseion and removed request for theseion June 10, 2025 14:54
@airween airween merged commit 348005a into owasp-modsecurity:v2/master Jun 11, 2025
82 checks passed
@airween airween added the 2.x Related to ModSecurity version 2.x label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theseion theseion theseion approved these changes
@fzipi fzipi fzipi approved these changes

Assignees

No one assigned

Labels

2.x Related to ModSecurity version 2.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@airween @theseion @fzipi