chore: fix cppcheck issues with v2.21.0#3593
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses new cppcheck (v2.21.0) style warnings in the standalone/ Apache-compat shim code by adding inline suppression directives, aiming to restore green CI for static analysis runs.
Changes:
- Added
// cppcheck-suppress funcArgNamesDifferentUnnamedannotations to hook/filter declarations that triggerfuncArgNamesDifferentUnnamedwarnings. - Adjusted a couple of multi-line declarations to include the suppressions where cppcheck reports the issues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| standalone/hooks.c | Adds cppcheck suppression comments to hook macro invocations that trigger funcArgNamesDifferentUnnamed. |
| standalone/filters.c | Adds cppcheck suppression comments to filter registration function signatures that trigger funcArgNamesDifferentUnnamed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
fzipi
approved these changes
Jul 1, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Fix cppcheck issues with the newest cppcheck version (2.21.0).
I think this warning is a false positive, and caused some wrong macro expansion.
why
Recent PRs' cppcheck were failed, eg. this.