-
-
Notifications
You must be signed in to change notification settings - Fork 522
Description
Subject of the issue
Would it possible to support converting a pull request back to draft? #1064 says this is not possible, but it appears the GraphQL API supports this, see https://github.com/orgs/community/discussions/45174#discussioncomment-4768134.
Maybe it would be good to have a separate input for this though and make it opt-in because some users might prefer to not convert PRs back to draft once they have been marked as ready.
Context
The reason for this feature request is mainly as another workaround to trigger other workflows for the pull request, probably the same which was proposed here: #48 (comment)
So the create-pull-request action creates the PR as draft, the user marks it as ready which then automatically runs the other workflows. And if create-pull-request updates the PR, it converts it back to draft again.
Unfortunately though by default on: pull_request does not include the ready_for_review activity (see documentation)1, so all workflows would have to explicit specify that activity type as well, which might be quite error-prone.
Not sure if this renders this workaround (and also the request to convert back to draft) pointless. What do you think?
Footnotes
-
I find it a bit weird that
ready_for_reviewis not included by default, but maybe the rationale is that by default workflows run for draft pull requests anyway, and therefore coveringready_for_reviewwould be redundant. Though that seems quite error-prone for users who configure their workflows to not run for draft PRs and then forget to consider that they have to explicitly specifyready_for_reviewas additional activity type. Might be worth asking GitHub support about this (?).
Edit: Have created https://github.com/orgs/community/discussions/139644 ↩