add Connection.set_verify, fix #255#1073
Merged
reaperhulk merged 4 commits intopyca:mainfrom May 13, 2022
Merged
Conversation
26ae0fb to
fb0136a
Compare
36ff812 to
15062ae
Compare
Member
Author
|
This is ready for review now! :) |
reaperhulk
approved these changes
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Connection.set_verifyandConnection.get_verify_modeto fix #255. Compared to #844 (a previous attempt which went stale) things got a bit simpler asConnectionnow already has its own_verify_helperand_verify_callbackattributes.I'm happy to add more tests if you feel that would be useful, I did not copy and adapt all the
Context.set_verifytests as that felt more like a maintenance burden than anything else. Line coverage is at 100% anyhow.CI will fail as we depend on the yet-unreleased cryptography bindings. :)